HyukjinKwon commented on code in PR #46129:
URL: https://github.com/apache/spark/pull/46129#discussion_r1573465371
##########
python/pyspark/sql/connect/session.py:
##########
@@ -325,7 +325,7 @@ def active(cls) -> "SparkSession":
active.__doc__ = PySparkSession.active.__doc__
- def table(self, tableName: str) -> DataFrame:
+ def table(self, tableName: str) -> ParentDataFrame:
Review Comment:
Seems like the arguments cannot be more specific type, and return types
can't be wider types
(https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides).
So it complains about the argument.
Let me just keep them all as parent dataframe for simplicity because those
types aren't user-facing anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
