HyukjinKwon commented on code in PR #46129:
URL: https://github.com/apache/spark/pull/46129#discussion_r1573466682
##########
python/pyspark/sql/tests/connect/test_connect_plan.py:
##########
@@ -333,6 +333,11 @@ def test_observe(self):
from pyspark.sql.connect.observation import Observation
class MockDF(DataFrame):
Review Comment:
This might be a breaking change if somebody inherits `pyspark.sql.DataFrame`
before, and it has it's own `__init__`. However, `__init__` is not really an
API, and users shouldn't really customize/use/invoke them directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
