ueshin commented on code in PR #46155: URL: https://github.com/apache/spark/pull/46155#discussion_r1575225973
########## python/pyspark/ml/stat.py: ########## @@ -22,7 +22,8 @@ from pyspark.ml.common import _java2py, _py2java from pyspark.ml.linalg import Matrix, Vector from pyspark.ml.wrapper import JavaWrapper, _jvm -from pyspark.sql.column import Column, _to_seq +from pyspark.sql.column import Column Review Comment: or import `_to_seq` later as the other files do? ########## python/pyspark/ml/connect/functions.py: ########## @@ -15,7 +15,7 @@ # limitations under the License. # from pyspark.ml import functions as PyMLFunctions -from pyspark.sql.connect.column import Column +from pyspark.sql.column import Column Review Comment: Should keep it as-is to be consistent with the classic `functions.py` if it changes to refer `classic`? ########## python/pyspark/ml/stat.py: ########## @@ -22,7 +22,8 @@ from pyspark.ml.common import _java2py, _py2java from pyspark.ml.linalg import Matrix, Vector from pyspark.ml.wrapper import JavaWrapper, _jvm -from pyspark.sql.column import Column, _to_seq +from pyspark.sql.column import Column Review Comment: Is this consistent with `functions.py`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
