HyukjinKwon commented on code in PR #46155: URL: https://github.com/apache/spark/pull/46155#discussion_r1575562214
########## python/pyspark/ml/connect/functions.py: ########## @@ -15,7 +15,7 @@ # limitations under the License. # from pyspark.ml import functions as PyMLFunctions -from pyspark.sql.connect.column import Column +from pyspark.sql.column import Column Review Comment: It is actually related to the type hints. We're using `pyspark.sql.Column` for type hints, and when we actually need to create the instance, we should use `pyspark.sql.classic.column import Column` or `pyspark.sql.connect.column import Column` .. it is also a bit messy. I should probably clean those up separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
