Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5792#discussion_r31367238
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala
---
@@ -62,4 +65,12 @@ private[history] abstract class
ApplicationHistoryProvider {
*/
def getConfig(): Map[String, String] = Map()
+ /**
+ * Writes out the event logs to the output stream provided. The logs
will be compressed into a
--- End diff --
Isn't that an implementation detail?
Or, if you want to enforce a zip file as the output, shouldn't it be a
`ZipOutputStream`? That actually sounds better since then it enforces a
stronger contract regardless of the underlying provider implementation.
Otherwise different providers may decide to return different types of files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
