Github user harishreedharan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5792#discussion_r31367519
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala
 ---
    @@ -62,4 +65,12 @@ private[history] abstract class 
ApplicationHistoryProvider {
        */
       def getConfig(): Map[String, String] = Map()
     
    +  /**
    +   * Writes out the event logs to the output stream provided. The logs 
will be compressed into a
    --- End diff --
    
    Yes, we can pass in a zip stream, but there is no real way to enforce the 
content formats (since each provider might use a different format). Anyway with 
legacy files, we'd have multiple files zipped (since for legacy files all 
attempts are the same files, I guess it is fine to just write each of the files 
as is. I will make that change to be consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to