ueshin commented on code in PR #46140:
URL: https://github.com/apache/spark/pull/46140#discussion_r1577043660
##########
connector/connect/server/src/test/scala/org/apache/spark/sql/connect/ui/SparkConnectServerListenerSuite.scala:
##########
@@ -37,7 +37,7 @@ class SparkConnectServerListenerSuite
private var kvstore: ElementTrackingStore = _
- private val jobTag = ExecuteJobTag("sessionId", "userId", "operationId")
+ private val jobTag = ExecuteJobTag("userId", "sessionId", "operationId")
Review Comment:
The original fix is
https://github.com/apache/spark/commit/dd6636b4e076c1c7fd3569ad509d28524a98d156.
I'm fine with it too, but I asked
https://github.com/apache/spark/pull/46140#issuecomment-2073342960 because I
worried the inconsistency with the similar API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
