yaooqinn commented on code in PR #46183:
URL: https://github.com/apache/spark/pull/46183#discussion_r1577367019
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DeduplicateRelations.scala:
##########
@@ -38,28 +38,31 @@ case class RelationWrapper(cls: Class[_], outputAttrIds:
Seq[Long])
object DeduplicateRelations extends Rule[LogicalPlan] {
override def apply(plan: LogicalPlan): LogicalPlan = {
val newPlan = renewDuplicatedRelations(mutable.HashSet.empty, plan)._1
- if (newPlan.find(p => p.resolved && p.missingInput.nonEmpty).isDefined) {
- // Wait for `ResolveMissingReferences` to resolve missing attributes
first
- return newPlan
+
+ def containsMissingInput(p: LogicalPlan) = {
Review Comment:
nit: How about?
```scala
def noMissingInput(p: LogicalPlan) = !p.exists(_.missingInput.nonEmpty)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
