peter-toth commented on code in PR #46183: URL: https://github.com/apache/spark/pull/46183#discussion_r1578042754
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DeduplicateRelations.scala: ########## @@ -38,28 +38,31 @@ case class RelationWrapper(cls: Class[_], outputAttrIds: Seq[Long]) object DeduplicateRelations extends Rule[LogicalPlan] { override def apply(plan: LogicalPlan): LogicalPlan = { val newPlan = renewDuplicatedRelations(mutable.HashSet.empty, plan)._1 - if (newPlan.find(p => p.resolved && p.missingInput.nonEmpty).isDefined) { - // Wait for `ResolveMissingReferences` to resolve missing attributes first - return newPlan + + def containsMissingInput(p: LogicalPlan) = { Review Comment: Fixed in https://github.com/apache/spark/pull/46183/commits/e47bfb94c7494b10c9cd8b48e4b377d0a39dd445. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org