gengliangwang commented on code in PR #46309:
URL: https://github.com/apache/spark/pull/46309#discussion_r1585629698
##########
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala:
##########
@@ -846,20 +846,23 @@ final class ShuffleBlockFetcherIterator(
// uses are shared by the UnsafeShuffleWriter (both writers use
DiskBlockObjectWriter
// which returns a zero-size from commitAndGet() in case no
records were written
// since the last call.
- val msg = s"Received a zero-size buffer for block $blockId from
$address " +
- s"(expectedApproxSize = $size,
isNetworkReqDone=$isNetworkReqDone)"
if (blockId.isShuffleChunk) {
// Zero-size block may come from nodes with hardware failures,
For shuffle chunks,
// the original shuffle blocks that belong to that zero-size
shuffle chunk is
// available and we can opt to fallback immediately.
- logWarning(msg)
+ logWarning(log"Received a zero-size buffer for block
${MDC(BLOCK_ID, blockId)} " +
+ log"from ${MDC(URI, address)} " +
+ log"(expectedApproxSize = ${MDC(NUM_BYTES, size)}, " +
+ log"isNetworkReqDone=${MDC(IS_NETWORK_REQUEST_DONE,
isNetworkReqDone)})")
pushBasedFetchHelper.initiateFallbackFetchForPushMergedBlock(blockId, address)
shuffleMetrics.incCorruptMergedBlockChunks(1)
// Set result to null to trigger another iteration of the while
loop to get either.
result = null
null
} else {
- throwFetchFailedException(blockId, mapIndex, address, new
IOException(msg))
+ throwFetchFailedException(blockId, mapIndex, address, new
IOException(
Review Comment:
let's just use `new IOException(msg.message)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
