gengliangwang commented on code in PR #46309:
URL: https://github.com/apache/spark/pull/46309#discussion_r1585638170
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -1813,13 +1818,13 @@ private[spark] object Utils
try {
process.destroyForcibly()
} catch {
- case NonFatal(e) => logWarning("Exception when attempting to kill
process", e)
+ case NonFatal(e) => logWarning(log"Exception when attempting to kill
process", e)
Review Comment:
This one is not needed
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -1813,13 +1818,13 @@ private[spark] object Utils
try {
process.destroyForcibly()
} catch {
- case NonFatal(e) => logWarning("Exception when attempting to kill
process", e)
+ case NonFatal(e) => logWarning(log"Exception when attempting to kill
process", e)
}
// Wait, again, although this really should return almost immediately
if (process.waitFor(timeoutMs, TimeUnit.MILLISECONDS)) {
Option(process.exitValue())
} else {
- logWarning("Timed out waiting to forcibly kill process")
+ logWarning(log"Timed out waiting to forcibly kill process")
Review Comment:
This one is not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
