chaoqin-li1123 commented on code in PR #46139:
URL: https://github.com/apache/spark/pull/46139#discussion_r1590520752
##########
python/docs/source/user_guide/sql/python_data_source.rst:
##########
@@ -59,8 +59,17 @@ Start by creating a new subclass of :class:`DataSource`.
Define the source name,
def reader(self, schema: StructType):
return FakeDataSourceReader(schema, self.options)
+ def streamReader(self, schema: StructType):
+ return FakeStreamReader(schema, self.options)
-**Step 2: Implement the Reader**
+ def simpleStreamReader(self, schema: StructType):
+ return SimpleStreamReader()
+
+ def streamWriter(self, schema: StructType, overwrite: bool):
+ return FakeStreamWriter(self.options)
+
Review Comment:
Section separated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]