HeartSaVioR commented on code in PR #45376:
URL: https://github.com/apache/spark/pull/45376#discussion_r1591714252
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -331,6 +331,7 @@ class Analyzer(override val catalogManager: CatalogManager)
extends RuleExecutor
Seq(
ResolveWithCTE,
ExtractDistributedSequenceID) ++
+ Seq(ResolveUpdateEventTimeWatermarkColumn) ++
Review Comment:
It's not guaranteed for all resolutions to happen in one loop. fixedPoint
means having iterations of application of the set of rules. That said, we
shouldn't still assume that child is resolved, and only make the rule to be
effective when child is resolved. I'll left a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
