dongjoon-hyun commented on code in PR #46440:
URL: https://github.com/apache/spark/pull/46440#discussion_r1595894126
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -980,9 +981,16 @@ valueExpression
| left=valueExpression operator=AMPERSAND right=valueExpression
#arithmeticBinary
| left=valueExpression operator=HAT right=valueExpression
#arithmeticBinary
| left=valueExpression operator=PIPE right=valueExpression
#arithmeticBinary
+ | left=valueExpression shiftOperator right=valueExpression
#shiftExpression
| left=valueExpression comparisonOperator right=valueExpression
#comparison
;
+shiftOperator
+ : LT LT
+ | GT GT
+ | GT GT GT
Review Comment:
This syntax is wrong because we should not allow spaces between `LT` and
`GT`.
For example, `< <` is a syntax error in other DBMS.
```
postgres=# SELECT 2 < < 1;
ERROR: syntax error at or near "<"
LINE 1: SELECT 2 < < 1;
```
But, this PR allows the following.
```
scala> sql("SELECT 2 < < 1").show()
+--------+
|(2 << 1)|
+--------+
| 4|
+--------+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
