yaooqinn commented on code in PR #46440:
URL: https://github.com/apache/spark/pull/46440#discussion_r1612922269
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseLexer.g4:
##########
@@ -69,6 +69,35 @@ lexer grammar SqlBaseLexer;
public void markUnclosedComment() {
has_unclosed_bracketed_comment = true;
}
+
+ /**
+ * When greater than zero, it's in the middle of parsing ARRAY/MAP/STRUCT
type.
+ */
+ public int complex_type_level_counter = 0;
+
+ /**
+ * Increase the counter by one when hits KEYWORD 'ARRAY', 'MAP', 'STRUCT'.
+ */
+ public void incComplexTypeLevelCounter() {
+ complex_type_level_counter++;
+ }
+
+ /**
+ * Decrease the counter by one when hits close tag '>' && the counter
greater than zero
+ * which means we are in the middle of complex type parsing. Otherwise, it's
a dangling
+ * GT token and we do nothing.
+ */
+ public void decComplexTypeLevelCounter() {
+ if (complex_type_level_counter > 0) complex_type_level_counter++;
Review Comment:
Nice catch! Thank you！
new tests added in the last commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
