uros-db commented on code in PR #46526: URL: https://github.com/apache/spark/pull/46526#discussion_r1598015529
########## sql/core/benchmarks/CollationBenchmark-jdk21-results.txt: ########## Review Comment: I would say that these results are somewhat better, but still not too good However - what's imperative right now is that we preserve the performance for UTF8_BINARY (by doing that if/else branch on supportsBinaryEquality). If we don't have a better approach at this moment, and we've already tried a couple of things - then I would say that's fine and we can proceed with the best of what we've got (which is this PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
