uros-db commented on code in PR #46526: URL: https://github.com/apache/spark/pull/46526#discussion_r1600457296
########## sql/core/benchmarks/CollationBenchmark-jdk21-results.txt: ########## Review Comment: apropos going through lower first, we need to be careful so as not to destroy the original data consider an example of finding the mode in ['a', 'B', 'B', 'A']. Here, correct answers would be: - 'a' - 'A' - 'B' but NOT: 'b' because that value is not found in the original data -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
