holdenk commented on code in PR #44755:
URL: https://github.com/apache/spark/pull/44755#discussion_r1580256318
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -5704,10 +5704,9 @@ class SQLConf extends Serializable with Logging with
SqlApiConf {
settings.synchronized { settings.asScala.toMap }
/**
- * Return all the configuration definitions that have been defined in
[[SQLConf]]. Each
- * definition contains key, defaultValue and doc.
+ * Return all the public configuration definitions that have been defined in
[[SQLConf]].
*/
- def getAllDefinedConfs: Seq[(String, String, String, String)] = {
+ def getAllDefinedConfs: Seq[(String, String, String, String, Set[String])] =
{
Review Comment:
This does change a public APIs type signature, I'm not sure it's super
important or widely used but given the stated goal of the PR change is to
improve the docs do we need this part? Or could a new internal API be
introduced if we need this functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
