nchammas commented on code in PR #44755:
URL: https://github.com/apache/spark/pull/44755#discussion_r1608468487
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -5704,10 +5704,9 @@ class SQLConf extends Serializable with Logging with
SqlApiConf {
settings.synchronized { settings.asScala.toMap }
/**
- * Return all the configuration definitions that have been defined in
[[SQLConf]]. Each
- * definition contains key, defaultValue and doc.
+ * Return all the public configuration definitions that have been defined in
[[SQLConf]].
*/
- def getAllDefinedConfs: Seq[(String, String, String, String)] = {
+ def getAllDefinedConfs: Seq[(String, String, String, String, Set[String])] =
{
Review Comment:
I think this is only used by us, and I also think it's the right place to
make a change judging from the docstring. We also have a rare chance to "get
away" with breaking public APIs due to the upcoming 4.0 release.
But it is indeed a public API. Do you prefer I just create a new API? It
will duplicate this existing API but include the new documentation groups as
well. I was thinking to also have this return a `Seq` of a case class with
descriptive attribute names, so we're not calling `._1` and the like everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
