Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31382319
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size, ii, vv)
}
}
+
+ override def argmax: Int = {
+ if (size == 0) {
+ -1
+ } else {
+
+ //grab first active index and value by default
+ var maxIdx = indices(0)
+ var maxValue = values(0)
+
+ foreachActive { (i, v) =>
+ if (v > maxValue) {
+ maxIdx = i
+ maxValue = v
+ }
+ }
+
+ // look for inactive values incase all active node values are
negative
+ if(size != values.size && maxValue <= 0){
--- End diff --
Sorry to be that guy, but it looks like this would also fail our current
convention that the first idx should be returned,
if maxValues is zero and if the activeIndex that has a value zero is lesser
than all inactive indices, something like.
val a = SparseVector(3, Array(0), Array(0))
It seems that argmax would return 1 in this case. (correct me is I'm wrong)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
