Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/6112#discussion_r31383352
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -717,6 +719,49 @@ class SparseVector(
new SparseVector(size, ii, vv)
}
}
+
+ override def argmax: Int = {
+ if (size == 0) {
+ -1
+ } else {
+
+ //grab first active index and value by default
+ var maxIdx = indices(0)
+ var maxValue = values(0)
+
+ foreachActive { (i, v) =>
+ if (v > maxValue) {
+ maxIdx = i
+ maxValue = v
+ }
+ }
+
+ // look for inactive values incase all active node values are
negative
+ if(size != values.size && maxValue <= 0){
--- End diff --
I had meant something like this.
val a = new SparseVector(3, Array(0, 1), Array(0, -1))
Till this block of code, the maxIdx would be 0 and maxValue would be 0 and
since the condition `size != values.size && maxValue <= 0` satisfies, it would
return the first inactive Index, i.e 2. However we want 0 to be returned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
