LuciferYang commented on code in PR #46736:
URL: https://github.com/apache/spark/pull/46736#discussion_r1613125740
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala:
##########
@@ -396,8 +396,6 @@ private[joins] class UnsafeHashedRelation(
val nKeys = readLong()
val nValues = readLong()
// This is used in Broadcast, shared by multiple tasks, so we use on-heap
memory
- // TODO(josh): This needs to be revisited before we merge this patch;
making this change now
- // so that tests compile:
Review Comment:
It seems that this was a reminder for the author to revisit this part of the
code before merging, but it was forgotten to be deleted when the code was
merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
