LuciferYang commented on code in PR #46736:
URL: https://github.com/apache/spark/pull/46736#discussion_r1615495409
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala:
##########
@@ -409,9 +407,6 @@ private[joins] class UnsafeHashedRelation(
val pageSizeBytes = Option(SparkEnv.get).map(_.memoryManager.pageSizeBytes)
.getOrElse(new SparkConf().get(BUFFER_PAGESIZE).getOrElse(16L * 1024 *
1024))
- // TODO(josh): We won't need this dummy memory manager after future
refactorings; revisit
Review Comment:
Thank you for your explanation. So, do we have a more suitable way to
re-describe this TODO? We can change to truly track it by creating a Jira and
updating the TODO description.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala:
##########
@@ -409,9 +407,6 @@ private[joins] class UnsafeHashedRelation(
val pageSizeBytes = Option(SparkEnv.get).map(_.memoryManager.pageSizeBytes)
.getOrElse(new SparkConf().get(BUFFER_PAGESIZE).getOrElse(16L * 1024 *
1024))
- // TODO(josh): We won't need this dummy memory manager after future
refactorings; revisit
Review Comment:
Thank you for your explanation @JoshRosen . So, do we have a more suitable
way to re-describe this TODO? We can change to truly track it by creating a
Jira and updating the TODO description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
