davidm-db commented on code in PR #46665:
URL: https://github.com/apache/spark/pull/46665#discussion_r1613161561
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -42,6 +42,29 @@ options { tokenVocab = SqlBaseLexer; }
public boolean double_quoted_identifiers = false;
}
+compoundOrSingleStatement
+ : singleStatement
+ | singleCompound
+ ;
+
+singleCompound
+ : compound SEMICOLON* EOF
+ ;
+
+compound
+ : BEGIN compoundBody END
+ ;
+
+// Last semicolon in body is optional.
+compoundBody
Review Comment:
As Milan said, we will reuse `compoundBody` in future in the blocks that
don't require `BEGIN` and `END` (if else, while, etc.).
One more reason is that in such blocks (that don't begin with `BEGIN`)
variable declaration is not allowed, so we need to have these cases separated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
