dbatomic commented on code in PR #46665:
URL: https://github.com/apache/spark/pull/46665#discussion_r1613213985
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -42,6 +42,29 @@ options { tokenVocab = SqlBaseLexer; }
public boolean double_quoted_identifiers = false;
}
+compoundOrSingleStatement
+ : singleStatement
+ | singleCompound
+ ;
+
+singleCompound
+ : compound SEMICOLON* EOF
+ ;
+
+compound
+ : BEGIN compoundBody END
+ ;
+
+// Last semicolon in body is optional.
+compoundBody
+ : compoundStatement (SEMICOLON+ compoundStatement)* SEMICOLON*
Review Comment:
Yeah, in POC we did what other languages do (e.g. in C++ you are allowed to
say `int x = 12;;;;`. Also, for single statements we do allow trailing
semicolons - `SELECT 1;;;;;` is valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
