mkaravel commented on code in PR #46732:
URL: https://github.com/apache/spark/pull/46732#discussion_r1617970107
##########
common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:
##########
@@ -526,10 +526,40 @@ public void testInitCap() throws SparkException {
assertInitCap("aB 世 de", "UNICODE_CI", "Ab 世 De");
assertInitCap("ÄBĆΔE", "UNICODE_CI", "Äbćδe");
// Case-variable character length
- assertInitCap("İo", "UTF8_BINARY", "İo");
- assertInitCap("İo", "UTF8_BINARY_LCASE", "İo");
- assertInitCap("İo", "UNICODE", "İo");
- assertInitCap("İo", "UNICODE_CI", "İo");
+ assertInitCap("İo", "UTF8_BINARY", "I\u0307o");
+ assertInitCap("İo", "UTF8_BINARY_LCASE", "İo");
+ assertInitCap("İo", "UNICODE", "I\u0307o");
Review Comment:
> "İ" was 2 separate characters,
We need to write it as two separate characters then, otherwise the rendering
can be very misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
