dbatomic commented on code in PR #46732:
URL: https://github.com/apache/spark/pull/46732#discussion_r1625746048
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java:
##########
@@ -296,6 +296,28 @@ public static String toLowerCase(final String target,
final int collationId) {
return UCharacter.toLowerCase(locale, target);
}
+ /**
+ * Convert the input string to titlecase using the ICU root locale rules.
+ *
+ * @param target the input string
Review Comment:
IMO, there is not much value in writing generic @param/@return comments. I
am fine with just main header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
