davidm-db commented on code in PR #46665:
URL: https://github.com/apache/spark/pull/46665#discussion_r1625792580
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -42,6 +42,28 @@ options { tokenVocab = SqlBaseLexer; }
public boolean double_quoted_identifiers = false;
}
+compoundOrSingleStatement
+ : singleStatement
+ | singleCompound
+ ;
+
+singleCompound
Review Comment:
So, if we want to be consistent with `statement` - `singleStatement` naming,
then this should be named `singleBeginEndCompoundBlock`, but that seemed too
much to me.
By this logic, `singleCompoundStatement` would mean it's a single
`compoundStatement` which it is not.
Due to this two reasons I left only `singleCompound`. We can change it, but
I would like to figure out better naming for other nodes, which I have no
better idea than what's already proposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
