cloud-fan commented on code in PR #46665: URL: https://github.com/apache/spark/pull/46665#discussion_r1631776102
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingLogicalOperators.scala: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.parser + +import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan + +/** + * Trait for all SQL Scripting logical operators that are product of parsing phase. + * These operators will be used by the SQL Scripting interpreter to generate execution nodes. + */ +sealed trait CompoundPlanStatement + +/** + * Logical operator representing result of parsing a single SQL statement + * that is supposed to be executed against Spark. + * It can also be a Spark expression that is wrapped in a statement. + * @param parsedPlan Result of SQL statement parsing. + * @param sourceStart Index of the first char of the statement in the original SQL script text. + * @param sourceEnd Index of the last char of the statement in the original SQL script text. + */ +case class SparkStatementWithPlan( + parsedPlan: LogicalPlan, + sourceStart: Int, + sourceEnd: Int) + extends CompoundPlanStatement { + + def getText(sqlScriptText: String): String = sqlScriptText.substring(sourceStart, sourceEnd) +} + +/** + * Logical operator for a compound body. Contains all statements within the compound body. + * @param collection Collection of statements within the compound body. + */ +case class CompoundBody(collection: List[CompoundPlanStatement]) extends CompoundPlanStatement Review Comment: In the Spark codebase, we mostly use `Seq` over `List` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
