yaooqinn commented on code in PR #46894:
URL: https://github.com/apache/spark/pull/46894#discussion_r1630824536
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala:
##########
@@ -63,22 +63,26 @@ object ExternalCatalogUtils {
bitSet
}
- def needsEscaping(c: Char): Boolean = {
+ @inline private final def needsEscaping(c: Char): Boolean = {
c < charToEscape.size() && charToEscape.get(c)
}
def escapePathName(path: String): String = {
- val builder = new StringBuilder()
- path.foreach { c =>
- if (needsEscaping(c)) {
- builder.append('%')
- builder.append(f"${c.asInstanceOf[Int]}%02X")
- } else {
- builder.append(c)
+ val firstIndex = path.indexWhere(needsEscaping)
+ if (firstIndex == -1) {
+ path
+ } else {
+ val builder = new StringBuilder(path.substring(0, firstIndex))
+ path.substring(firstIndex).foreach { c =>
+ if (needsEscaping(c)) {
+ builder.append('%')
+ builder.append(f"${c.asInstanceOf[Int]}%02X")
+ } else {
+ builder.append(c)
+ }
}
+ builder.toString()
}
-
- builder.toString()
}
Review Comment:
Will address this in a separate PR if you don't mind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
