LuciferYang commented on code in PR #46894:
URL: https://github.com/apache/spark/pull/46894#discussion_r1634141448
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala:
##########
@@ -60,28 +60,42 @@ object ExternalCatalogUtils {
Array(' ', '<', '>', '|').foreach(bitSet.set(_))
}
- bitSet
+ (bitSet, bitSet.size)
}
- def needsEscaping(c: Char): Boolean = {
- c < charToEscape.size() && charToEscape.get(c)
+ private final val HEX_CHARS = "0123456789ABCDEF".toCharArray
+
+ @inline final def needsEscaping(c: Char): Boolean = {
+ c < sizeOfCharToEscape && charToEscape.get(c)
}
def escapePathName(path: String): String = {
- val builder = new StringBuilder()
- path.foreach { c =>
- if (needsEscaping(c)) {
- builder.append('%')
- builder.append(f"${c.asInstanceOf[Int]}%02X")
- } else {
- builder.append(c)
+ if (path == null || path.isEmpty) {
+ return path
+ }
+ val length = path.length
+ var firstIndex = 0
+ while (firstIndex < length && !needsEscaping(path.charAt(firstIndex))) {
+ firstIndex += 1
+ }
+ if (firstIndex == 0 && !needsEscaping(path.charAt(0))) {
Review Comment:
should be `if (firstIndex == length)` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
