mathiasschw-db commented on code in PR #20:
URL: https://github.com/apache/spark-connect-go/pull/20#discussion_r1657096901
##########
client/channel/channel.go:
##########
@@ -35,22 +37,22 @@ import (
// Reserved header parameters that must not be injected as variables.
var reservedParams = []string{"user_id", "token", "use_ssl"}
-// The ChannelBuilder is used to parse the different parameters of the
connection
+// Builder is used to parse the different parameters of the connection
// string according to the specification documented here:
//
//
https://github.com/apache/spark/blob/master/connector/connect/docs/client-connection-string.md
-type ChannelBuilder struct {
+type Builder struct {
Review Comment:
This avoid the stuttering interface that it had before
(channel.ChannelBuilder, now channel.Builder). The latter is considered best
practice Go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
