mathiasschw-db commented on code in PR #20: URL: https://github.com/apache/spark-connect-go/pull/20#discussion_r1657136729
########## go.mod: ########## @@ -15,7 +15,7 @@ module github.com/apache/spark-connect-go/v1 -go 1.19 +go 1.21 Review Comment: This is not strictly necessary for the code itself but some of the `error.Is` functionality will not work in 1.19. It will compile fine and work with whatever features existed in 1.19 though ########## go.mod: ########## @@ -15,7 +15,7 @@ module github.com/apache/spark-connect-go/v1 -go 1.19 +go 1.21 Review Comment: This is not strictly necessary for the code itself but some of the `error.Is` functionality will not work in 1.19. It will compile fine and work with whatever features existed in 1.19 though. Our tests assume (and check) 1.21 functionality -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
