Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/714#issuecomment-42748190
Hey @witgo @andrewor14. I thought I commented earlier but it appears the
comment didn't get posted.
I think it would be a good idea to validate this at the time of `SparkConf`
construction rather than have validations scattered throughout the code.
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkConf.scala#L213
Also - it would be good to echo back the value that was set to the user.
Sometimes users don't know where a configuration option is coming from:
```
if (memoryFraction > 1 || memoryFraction < 0) {
val msg = s"spark.storage.memoryFraction should be between 0 and 1 (was
'$memoryFraction')."
throw new IllegalArgumentException(msg)
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---