Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/714#discussion_r12501550
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
@@ -76,6 +76,16 @@ class ExternalAppendOnlyMap[K, V, C](
private val maxMemoryThreshold = {
val memoryFraction =
sparkConf.getDouble("spark.shuffle.memoryFraction", 0.3)
val safetyFraction =
sparkConf.getDouble("spark.shuffle.safetyFraction", 0.8)
+
+ if (memoryFraction > 1 && memoryFraction <= 0) {
+ throw new Exception("spark.shuffle.memoryFraction should be between
0 and 1.")
+ }
+
+ if (safetyFraction > 1 && safetyFraction <= 0) {
+ throw new Exception("spark.shuffle.safetyFraction should be between
0 and 1.")
+ }
+
--- End diff --
removed and updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
