c27kwan commented on code in PR #47304:
URL: https://github.com/apache/spark/pull/47304#discussion_r1674224891
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala:
##########
@@ -1364,4 +1375,20 @@ class AnalysisErrorSuite extends AnalysisTest with
DataTypeErrorsBase {
messageParameters = Map(
"expr" -> "\"_w0\"",
"exprType" -> "\"MAP<STRING, STRING>\""))
+
+ test("SPARK-48871: AllowsNonDeterministicExpression allow lists
non-deterministic expressions") {
Review Comment:
Test name needs update
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -143,6 +143,14 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog with QueryErrorsB
errorClass, missingCol, orderedCandidates, a.origin)
}
+ private def operatorAllowsNonDeterministicExpressions(plan: LogicalPlan):
Boolean = {
Review Comment:
quick javadoc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
