cloud-fan commented on code in PR #47304:
URL: https://github.com/apache/spark/pull/47304#discussion_r1674945927
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala:
##########
@@ -1364,4 +1372,20 @@ class AnalysisErrorSuite extends AnalysisTest with
DataTypeErrorsBase {
messageParameters = Map(
"expr" -> "\"_w0\"",
"exprType" -> "\"MAP<STRING, STRING>\""))
+
+ test("SPARK-48871: SupportsNonDeterministicExpression allows
non-deterministic expressions") {
+ val nonDeterministicExpressions = Seq(new Rand())
+ val tolerantPlan =
+ SupportsNonDeterministicExpressionTestOperator(
+ nonDeterministicExpressions, tolerateNonDeterministicExpression = true)
Review Comment:
```suggestion
nonDeterministicExpressions, allowNonDeterministicExpression = true)
```
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala:
##########
@@ -1364,4 +1372,20 @@ class AnalysisErrorSuite extends AnalysisTest with
DataTypeErrorsBase {
messageParameters = Map(
"expr" -> "\"_w0\"",
"exprType" -> "\"MAP<STRING, STRING>\""))
+
+ test("SPARK-48871: SupportsNonDeterministicExpression allows
non-deterministic expressions") {
+ val nonDeterministicExpressions = Seq(new Rand())
+ val tolerantPlan =
+ SupportsNonDeterministicExpressionTestOperator(
+ nonDeterministicExpressions, tolerateNonDeterministicExpression = true)
+ assertAnalysisSuccess(tolerantPlan)
+
+ val intolerantPlan =
+ SupportsNonDeterministicExpressionTestOperator(
+ nonDeterministicExpressions, tolerateNonDeterministicExpression =
false)
Review Comment:
```suggestion
nonDeterministicExpressions, allowNonDeterministicExpression = false)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
