JoshRosen commented on PR #47334: URL: https://github.com/apache/spark/pull/47334#issuecomment-2226123958
> @JoshRosen , this backporting PR looks exceptional to me because we don't do this usually. Just a question. Did we break any binary compatibility from 3.4.x somewhere? @dongjoon-hyun, you're right that previously this has not been standard practice. From the check results, OSS Apache Spark 3.5.2-snapshot remains binary-compatible with 3.5.0 and, transitively, because 3.5.0 was binary compatible with 3.4.0 and so it should also be compatible with 3.4.0 and so on. I'm proposing this change because: - It doesn't _hurt_ and, strictly speaking, strengthens our tests to detect more potential incpompatibilies. - It slightly reduces merge conflicts for any future patches in 4.x which need to be backported to 3.5.x and involve new MiMa excludes (such as https://issues.apache.org/jira/browse/SPARK-46480) - It reduces merge conflicts / simplifies certain workflows in our internal fork of Spark (where we also use MiMa checks). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
