JoshRosen commented on PR #47334: URL: https://github.com/apache/spark/pull/47334#issuecomment-2226324984
> Here is a general counter example in my mind. (This is not a specific to this PR's deletion). > > 1. `v3.4.0` has a public API `x`. > 2. `v3.5.0` renames `x` to `y` with the exception rules. > 3. This PR removes all exclusion rules after switching to `v3.5.0` because `x` is supposed not to exist. > 4. `v3.5.2` adds a new public API `x` with different signatures because this is new at 3.5.2. > > Then, `v3.5.2` has an incompatibility on API `x` against `v3.4.x ~ v3.5.1`. WDYT? In the case where we've previously renamed `x` to `y` and have added a missing method exclusion for `x`, then subsequently re-introduce it with a different signature: in that case, wouldn't the previous incompatible renaming _itself_ have been a binary incompatibility? --- I was hoping this would be straightforward and easy, but if we can't gain consensus then I'm just as glad to abandon this and close without merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
