mingkangli-db commented on code in PR #47374:
URL: https://github.com/apache/spark/pull/47374#discussion_r1688676493
##########
connect/server/src/main/scala/org/apache/spark/sql/connect/execution/ExecuteThreadRunner.scala:
##########
@@ -115,7 +116,8 @@ private[connect] class ExecuteThreadRunner(executeHolder:
ExecuteHolder) extends
case e: Throwable =>
logDebug(s"Exception in execute: $e")
// Always cancel all remaining execution after error.
-
executeHolder.sessionHolder.session.sparkContext.cancelJobsWithTag(executeHolder.jobTag)
+
executeHolder.sessionHolder.session.sparkContext.cancelJobsWithTag(executeHolder.jobTag,
+ "Exception in execute:" + ExceptionUtils.getStackTrace(e))
Review Comment:
Sounds good, I also switched to using `Utils.exceptionString` because it
seems to be more commonly used than the other in the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
