cloud-fan commented on code in PR #47374:
URL: https://github.com/apache/spark/pull/47374#discussion_r1689165699
##########
connect/server/src/main/scala/org/apache/spark/sql/connect/execution/ExecuteThreadRunner.scala:
##########
@@ -115,7 +115,8 @@ private[connect] class ExecuteThreadRunner(executeHolder:
ExecuteHolder) extends
case e: Throwable =>
logDebug(s"Exception in execute: $e")
// Always cancel all remaining execution after error.
-
executeHolder.sessionHolder.session.sparkContext.cancelJobsWithTag(executeHolder.jobTag)
+
executeHolder.sessionHolder.session.sparkContext.cancelJobsWithTag(executeHolder.jobTag,
+ "Exception in execute: " + Utils.exceptionString(e))
Review Comment:
I'm a bit worried about putting the full exception string in the reason
field, as it can be very long. How about `A job with the same tag '$tagName'
has failed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
