dongjoon-hyun commented on code in PR #47516:
URL: https://github.com/apache/spark/pull/47516#discussion_r1699073617
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala:
##########
@@ -935,21 +939,46 @@ class SQLMetricsSuite extends SharedSparkSession with
SQLMetricsTestUtils
assert(windowGroupLimit.get.metrics("numOutputRows").value == 2L)
}
+ test("SPARK-49038: Correctly filter out invalid accumulator metrics") {
+ val metric1 = SQLMetrics.createTimingMetric(sparkContext, name = "m")
+ val metric2 = SQLMetrics.createTimingMetric(sparkContext, name = "m")
+ val metric3 = SQLMetrics.createTimingMetric(sparkContext, name = "m")
+ val metric4 = SQLMetrics.createTimingMetric(sparkContext, name = "m")
+ val metric5 = SQLMetrics.createTimingMetric(sparkContext, name = "m")
+ val metric6 = SQLMetrics.createTimingMetric(sparkContext, name = "m")
+ val metric7 = SQLMetrics.createTimingMetric(sparkContext, name = "m")
Review Comment:
To be clear, could you use different names instead of the same name, `m`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
