cloud-fan commented on PR #47516: URL: https://github.com/apache/spark/pull/47516#issuecomment-2261818851
I'm not convinced by the added test, as it calls `SQLMetrics.stringValue` directly. In reality, the `values` parameter of this method comes from accumulator values from spark events. Are you sure it may contain -1? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
