cloud-fan commented on code in PR #47442:
URL: https://github.com/apache/spark/pull/47442#discussion_r1701365767
##########
sql/core/src/test/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNodeSuite.scala:
##########
@@ -77,11 +93,157 @@ class SqlScriptingExecutionNodeSuite extends SparkFunSuite
{
TestLeafStatement("three"),
TestNestedStatementIterator(Seq(TestLeafStatement("four"),
TestLeafStatement("five")))))
.getTreeIterator
- val statements = iter.map {
- case TestLeafStatement(v) => v
- case _ => fail("Unexpected statement type")
- }.toList
-
+ val statements = iter.map(extractStatementValue).toSeq
assert(statements === Seq("one", "two", "three", "four", "five"))
}
+
+ test("if else - enter body of the IF clause") {
+ val iter = TestNestedStatementIterator(Seq(
+ TestIfElse(
+ conditions = Seq(
+ TestSingleStatement("con1")
Review Comment:
It might make the test code simpler, but it complicates the abstraction.
Can't we inline the code of `StatementBooleanEvaluator` into
`IfElseStatementExec`, and use real queries as conditions in the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
