davidm-db commented on code in PR #47442:
URL: https://github.com/apache/spark/pull/47442#discussion_r1702347272
##########
sql/core/src/test/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNodeSuite.scala:
##########
@@ -38,21 +40,32 @@ class SqlScriptingExecutionNodeSuite extends SparkFunSuite {
case class TestBody(statements: Seq[CompoundStatementExec]) extends
CompoundBodyExec(statements)
- case class TestSparkStatementWithPlan(testVal: String)
+ case class TestIfElse(
+ conditions: Seq[SingleStatementExec],
+ conditionalBodies: Seq[TestBody],
+ elseBody: Option[TestBody],
Review Comment:
good catch - it's simply a leftover from before before we simplified tests a
lot... I've actually removed all `Test*` implementations of non leaf statements
- we need to override only leaf statements for testing purposes. Abstractions
are done properly, so real implementations of execution nodes from
`SqlScriptingExecutionNode` can handle dummy implementations of leaf statements
in tests. Should be really clean now, I think...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
