davidm-db commented on code in PR #47462:
URL: https://github.com/apache/spark/pull/47462#discussion_r1706719582


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -195,12 +196,33 @@ class AstBuilder extends DataTypeAstBuilder
       case _ =>
     }
 
-    val labelText = beginLabelCtx.
+    beginLabelCtx.
       
map(_.multipartIdentifier().getText).getOrElse(java.util.UUID.randomUUID.toString).

Review Comment:
   nit: for a bit cleaner code, let's move `getOrElse` to the new line and also 
let's start lines with . instead of ending them with .
   this makes it clear immediately that this is a function call extending from 
the previous line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to