miland-db commented on code in PR #47462:
URL: https://github.com/apache/spark/pull/47462#discussion_r1706716394
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala:
##########
@@ -294,7 +294,22 @@ class SqlScriptingParserSuite extends SparkFunSuite with
SQLHelper {
parameters = Map("varName" -> "`testVariable`", "lineNumber" -> "4"))
}
- // TODO Add test for INVALID_VARIABLE_DECLARATION.NOT_ALLOWED_IN_SCOPE
exception
+
Review Comment:
nit: let's keep one line between tests
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala:
##########
@@ -527,6 +542,57 @@ class SqlScriptingParserSuite extends SparkFunSuite with
SQLHelper {
.getText == "SELECT 42")
}
+
Review Comment:
nit: same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
