cloud-fan commented on code in PR #47660:
URL: https://github.com/apache/spark/pull/47660#discussion_r1708989636
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -68,7 +68,7 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
throw QueryCompilationErrors.unsupportedTableOperationError(ident,
"REPLACE COLUMNS")
case a @ AlterColumn(ResolvedTable(catalog, ident, table: V1Table, _), _,
_, _, _, _, _)
- if isSessionCatalog(catalog) =>
+ if isSessionCatalog(catalog) && !isV2SessionCatalog(catalog) =>
Review Comment:
maybe we should only have one method `supportsV1Command(catalog)`, and it
returns true only if the catalog name is `spark_catalog` and there is no custom
catalog to override it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
