cloud-fan commented on code in PR #47660:
URL: https://github.com/apache/spark/pull/47660#discussion_r1711634486
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -623,6 +618,20 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
}
private object DatabaseInSessionCatalog {
+ def unapply(resolved: ResolvedNamespace): Option[String] = resolved match {
+ case ResolvedNamespace(catalog, _, _) if !supportsV1Command(catalog) =>
None
Review Comment:
it's a bit weird to check `supportsV1Command` in `DatabaseInSessionCatalog`.
Shall we rename it to `ResolvedV1Database`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
