jingz-db commented on code in PR #47574:
URL: https://github.com/apache/spark/pull/47574#discussion_r1710413375
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/state/StatePartitionReader.scala:
##########
@@ -161,6 +188,16 @@ class StatePartitionReader(
row.update(2, partition.partition)
row
}
+
+ private def unifyStateRowPairWithTTL(pair: (UnsafeRow, UnsafeRow)):
InternalRow = {
Review Comment:
Shall we place this function and the row schema definition (code
[here](https://github.com/apache/spark/pull/47574/files#diff-d65c7a77b70d4f549969ddd852d83e0a337bfa8c22e1b0a76f8e1ad5c96982d8R187))
into one single class/object so that all following TWS state vars can define
their schema/unify function in the class? This way we can probably have better
code readability for future List/Map state reader implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
